Improvements to move_to_target #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle overshoot (change direction) * Calculate speed per second instead of per loop * Adjust thresholds for stopping
|
Thanks! I wanted to fix overshooting myself, but I didn't have time to do that. |
|
The speed per loop varies wildly for me, but the speed per second is much more stable. A stable number is easier to compare against, and should be the same on different computers too |
|
Oh, I didn't know that the speed can be different - was quite stable for me. Good to know, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh, and also doubled number of connection attempts since my MacBook fails half the time otherwise.